New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix displaying delegate name - Closes #1080 #1082

Merged
merged 2 commits into from Aug 17, 2018

Conversation

3 participants
@slaweet
Member

slaweet commented Aug 16, 2018

What was the problem?

When registering a delegate, it never got the transaction confirmed, thus never showed delegate name and "Forging" tab

How did I fix it?

Similarly to Hub, I stopped checking unconfirmed transactions, so that as long as there is a pending transaction, it will keep trying to fetch confirmed transactions, until the pending transaction is in the confirmed list.

How to test it?

  • Login to a non-delegate account
  • Register a delegate
  • Wait for the transaction to be confirmed
  • Check that the delegate name and Forging tab is displayed.

Review checklist

  • The PR solves #1080
  • All new code is covered with unit tests
  • All new features are covered with e2e tests
  • All new code follows best practices
🐛 Stop checking unconfirmed transactions
... to make sure we won't miss confirmed transactions

@slaweet slaweet self-assigned this Aug 16, 2018

@slaweet slaweet added this to Issues in Version 2.0.0 via automation Aug 16, 2018

@slaweet slaweet moved this from Issues to Pull Requests in Version 2.0.0 Aug 16, 2018

@slaweet slaweet requested a review from faival Aug 17, 2018

Bump lisk-elements version to 1.0.0
- update tests not to use invalid public key (non-hex)
- update sign/verify Message tests because the algorithm changed
@faival

faival approved these changes Aug 17, 2018

thanks @slaweet !

@slaweet slaweet requested a review from Efefefef Aug 17, 2018

@slaweet slaweet merged commit 8ed57f7 into 2.0.0 Aug 17, 2018

4 checks passed

Jenkins test deployment Commit was deployed to test
Details
continuous-integration/jenkins/pr-merge This commit looks good
Details
coverage/coveralls Coverage remained the same at 90.548%
Details
security/snyk - package.json (LiskHQ) No new issues
Details

Version 2.0.0 automation moved this from Pull Requests to Merged Pull Requests Aug 17, 2018

@slaweet slaweet deleted the 1080-fix-delegate branch Aug 17, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment