Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

malformed transaction posted on peer/transactions makes the server crash #13

Closed
fix opened this Issue Mar 22, 2016 · 0 comments

Comments

Projects
None yet
2 participants
@fix
Copy link
Contributor

commented Mar 22, 2016

Wondering why all servers of testnet recently crashed?

if you post a transaction similar to this (no recipientId)

{
  amount: 100000000,
  asset: {},
  fee: 10000000,
  id: "8233217121578014269",
  senderPublicKey: "5f7400e4c1ac021617fbc93bb9a51661855ce29d591896821252300ff1e437f3",
  signSignature: "8923786b20813bb9ac69e6c18a124918631dc3ea299d68428a8268000c979cebb2efc4441a7efa6713d09454b32d86292a6a7b22c49310bb64a674cc9b636008",
  signature: "0a42096400682a0389e5d61dcefa470be857dfdc38b44d0987b66658dbc596a39aaeea712896cbd78aca707ce9ad5fdff01576e0b466302711ff50b8dfc06001",
  timestamp: 30139064,
  type: 0
}

Boom!

details on the server log:

fatal Domain master { 
  message: 'Cannot read property 'toLowerCase' of undefined',
  stack: 'TypeError: Cannot read property 'toLowerCase' of undefined
             at l.verify (/home/liskdelegate/lisk-0.1.1-Linux-x86_64/app.js:10:19543)
             at l.verify (/home/liskdelegate/lisk-0.1.1-Linux-x86_64/app.js:13:646)
             at /home/liskdelegate/lisk-0.1.1-Linux-x86_64/app.js:11:1208
             at EventEmitter.<anonymous> (/home/liskdelegate/lisk-0.1.1-Linux-x86_64/app.js:12:29429)
             at Socket.<anonymous> (/home/liskdelegate/lisk-0.1.1-Linux-x86_64/node_modules/dblite/build/dblite.node.js:379:22)
             at Socket.emit (events.js:107:17)
             at readableAddChunk (_stream_readable.js:163:16)
             at Socket.Readable.push (_stream_readable.js:126:10)
             at Pipe.onread (net.js:540:20)'
 }

@karmacoma karmacoma added the bug label Mar 22, 2016

@karmacoma karmacoma added this to the Mainnet Launch milestone Mar 22, 2016

@karmacoma karmacoma self-assigned this Mar 22, 2016

@fix fix changed the title malformed transaction posted on peer/transactions make the server crash malformed transaction posted on peer/transactions makes the server crash Mar 22, 2016

@karmacoma karmacoma closed this in eee1154 Mar 22, 2016

karmacoma added a commit that referenced this issue Apr 2, 2016

Fixes #13. Checking for presence of recipientId.
Don’t transform case, regular expression already case-insensitive.

Isabello pushed a commit that referenced this issue Oct 17, 2017

Isabella Dell
Merge pull request #13 from LiskHQ/0.9.10-duplicated-delegates-with-s…
…ilent-validation-fail

Duplicated delegates fix with silent validation failure
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.