Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
Fix rank parameter of delegates API endpoint #1988
By making an API request to the
The response contains all delegates.
Steps to reproduce
Make API call
Which version(s) does this affect? (Environment, OS, etc...)
Yes, I can work on this issue @MaciejBaj.
As far as I understand, currently there is no rank parameter that we take in the /api/delegates endpoint. We need to change this endpoint to take in rank parameter and return the delegates having the same rank parameter.
The type of rank field is number, so it would look something like: /api/delegates?rank=5.
Like @Tschakki said, one can also query api/delegates?orderBy=rank:asc
Thx for looking into it @Mastermaulik !
I think the most convenient will be to simply remove it, as this endpoint is not really needed... The same can be achieved with the alternative request api/delegates?orderBy=rank:asc, as you mentioned.
This is just a recommendation, if you want to fix it or already started, go ahead :)
This was referenced
May 17, 2018
referenced this issue
May 24, 2018
@Tschakki after reading all your comments, IMHO I think this parameter should be kept. I don't see how it can bother anyone. The use case will arrive with the time.
@Tschakki I reviewed the discussion as well the relevant code. Our db layer is written in a way to to accept filters fo only persisted database column. While
@diego-G Providing composite filter is what we should do, but in current scope. Currently its get more complicated. e.g. If some one request
For now its seems feasible to just remove the