Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use npx instead of ./node_modules/.bin/ #2920

Closed
diego-G opened this issue Feb 20, 2019 · 0 comments

Comments

Projects
1 participant
@diego-G
Copy link
Member

commented Feb 20, 2019

Expected behavior

We should use the new npx feature to execute our dependencies.

Actual behavior

We still execute dependencies through the old way.
https://github.com/LiskHQ/lisk/blob/01c0125c589890e5e065dbc3ac942d9e1044c86f/Gruntfile.js#L31

Note: npx is executed by default inside package.json, therefore it's not necessary to use it on the scripts.

Which version(s) does this affect? (Environment, OS, etc...)

1.5

@diego-G diego-G self-assigned this Feb 20, 2019

@diego-G diego-G added this to To do in Version 1.6.0 via automation Feb 20, 2019

@MaciejBaj MaciejBaj added this to Sprint Backlog in Lisk Pipelines Feb 21, 2019

MaciejBaj added a commit that referenced this issue Feb 21, 2019

Merge pull request #2921 from LiskHQ/2920-use_npx
Use npx instead ./node_modules/.bin/ - Closes #2920

Version 1.6.0 automation moved this from To do to Done Feb 21, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.