Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add jest tests to CI pipeline #2946

Closed
yatki opened this issue Feb 25, 2019 · 2 comments

Comments

Projects
2 participants
@yatki
Copy link
Member

commented Feb 25, 2019

Expected behavior

  • We need to run Jest tests alongside with mocha tests on Jenkins.
  • We should be able to run jest tests and mocha test suites at once with a top level command. Eg "npm test:unit": "run-p mocha:unit jest:unit"
  • Merge code coverage from both test runners.

Actual behavior

  • Jenkinsfile is not configured to run Jest tests.
  • We don't have a top level command to run test runners.

Steps to reproduce

Which version(s) does this affect? (Environment, OS, etc...)

1.6.0

@yatki yatki added *easy test labels Feb 25, 2019

@yatki yatki self-assigned this Feb 25, 2019

@yatki yatki added this to To do in Version 1.6.0 via automation Feb 25, 2019

@yatki yatki changed the title Add jest tests to ci pipeline Add jest tests to CI pipeline Feb 25, 2019

@michielmulders

This comment has been minimized.

Copy link
Contributor

commented Mar 4, 2019

Added --passWithNotests flag for jest:integration and jest:functional as the absence of tests makes Jenkins fail.

@michielmulders

This comment has been minimized.

Copy link
Contributor

commented Mar 5, 2019

Jest added to Jenkins script and create a command that executes all tests for a certain type e.g. unit. However, using this command, the success/failure of the separate commands are lost between all the logs as they execute in parallel.

Todo @yatki

  • Work on merging code coverage
  • Possibly move the .code-coverage from root to test as the coverage from Mocha is located under /test. If doing so, check Jenkins script cleanup function (post step) for the Jest steps as paths need to be changed.

We can safely remove the --passWithNotests flag in package.json script for running Jest tests whenever we have tests for each type (functional and integration).

@michielmulders michielmulders moved this from To do to In progress in Version 1.6.0 Mar 6, 2019

@yatki yatki added *medium and removed *easy labels Mar 15, 2019

Version 1.6.0 automation moved this from In progress to Done Mar 20, 2019

MaciejBaj added a commit that referenced this issue Mar 20, 2019

Merge pull request #3094 from LiskHQ/2946-add_jest_CI_pipeline
Add jest tests to CI pipeline - Closes #2946
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.