Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove insecure and not used chain actions #3033

Closed
lsilvs opened this issue Mar 7, 2019 · 0 comments

Comments

Projects
4 participants
@lsilvs
Copy link
Member

commented Mar 7, 2019

Expected behavior

Expect for chain module to expose only relevant actions

Actual behavior

It exposes getForgersKeyPairs which should never be accessed from other modules.
Plus, in order to avoid braking changes in the future, we should only expose relevant actions and just add new ones when justified.

Steps to reproduce

apiChannel.invoke('chain:getForgersKeyPairs')

Which version(s) does this affect? (Environment, OS, etc...)

1.6

@lsilvs lsilvs added this to To do in Version 1.6.0 via automation Mar 7, 2019

@MaciejBaj MaciejBaj added the security label Mar 13, 2019

@shuse2 shuse2 assigned michielmulders and unassigned shuse2 Mar 13, 2019

@michielmulders michielmulders moved this from To do to In progress in Version 1.6.0 Mar 20, 2019

Version 1.6.0 automation moved this from In progress to Done Mar 22, 2019

MaciejBaj added a commit that referenced this issue Mar 22, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.