Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix protocol version parsing with double digits #3081

Closed
limiaspasdaniel opened this issue Mar 14, 2019 · 0 comments

Comments

Projects
1 participant
@limiaspasdaniel
Copy link
Member

commented Mar 14, 2019

Expected behavior

Protocol version should be parsing correctly the hard part.
When 1.0 -> 1.
When 10.0 -> 10

Actual behavior

The hard part of protocolVersion ([1].0) of incoming peers is not being correctly parsed, only taking into account the first digit.
This fails if it is > 9, right know having:
When 10.0 -> 1.

Steps to reproduce

Which version(s) does this affect? (Environment, OS, etc...)

@limiaspasdaniel limiaspasdaniel self-assigned this Mar 14, 2019

@limiaspasdaniel limiaspasdaniel added this to To do in Version 1.6.0 via automation Mar 14, 2019

@limiaspasdaniel limiaspasdaniel changed the title Fix protocol version parsing Fix protocol version parsing with double digits Mar 15, 2019

Version 1.6.0 automation moved this from To do to Done Mar 15, 2019

MaciejBaj added a commit that referenced this issue Mar 15, 2019

Merge pull request #3083 from LiskHQ/3081-Fix_protocol_version_parsing
Fix protocol version parsing with double digits - Closes #3081
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.