Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error objects not being correctly logged #3092

Closed
limiaspasdaniel opened this issue Mar 15, 2019 · 0 comments

Comments

Projects
3 participants
@limiaspasdaniel
Copy link
Member

commented Mar 15, 2019

Expected behavior

Error objects should be logged correctly

Actual behavior

Now that we are using Error object instead of plain strings to represent errors, it seems some of them are not being properly parsed when logging, resulting in or either an empty log for that error or stringifying the whole Error object.

Steps to reproduce

For example, run the applicacion and halt it manually. Some errors occur on cleanup time but they are not being printed out because of the reasons mentioned above.

Which version(s) does this affect? (Environment, OS, etc...)

development

@limiaspasdaniel limiaspasdaniel added the bug label Mar 15, 2019

@limiaspasdaniel limiaspasdaniel self-assigned this Mar 15, 2019

@limiaspasdaniel limiaspasdaniel added this to To do in Version 1.6.0 via automation Mar 15, 2019

@lsilvs lsilvs removed this from To do in Version 1.6.0 Mar 19, 2019

@lsilvs lsilvs added this to To do in Version 1.6.0 via automation Mar 19, 2019

@MaciejBaj MaciejBaj added this to Sprint Candidate in Lisk Pipelines Mar 20, 2019

@MaciejBaj MaciejBaj moved this from To do to In progress in Version 1.6.0 Mar 20, 2019

@MaciejBaj MaciejBaj added the *medium label Mar 20, 2019

@MaciejBaj MaciejBaj assigned lsilvs and unassigned limiaspasdaniel Mar 22, 2019

@lsilvs lsilvs added *easy and removed *medium labels Mar 22, 2019

Version 1.6.0 automation moved this from In progress to Done Mar 22, 2019

MaciejBaj added a commit that referenced this issue Mar 22, 2019

Merge pull request #3155 from LiskHQ/3092-error-not-being-logged
Error objects not being correctly logged - Closes #3092
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.