Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert use of "npm start" in Dockerfile and docker-compose.yml #3264

Closed
lsilvs opened this issue Apr 4, 2019 · 0 comments

Comments

Projects
2 participants
@lsilvs
Copy link
Member

commented Apr 4, 2019

Expected behavior

As npm start doesn't exit gracefully, it should be avoided until #3210 is fixed.

Actual behavior

Dockerfile uses npm start

Which version(s) does this affect? (Environment, OS, etc...)

1.6

@lsilvs lsilvs self-assigned this Apr 4, 2019

@lsilvs lsilvs added this to To do in Version 1.6.0 via automation Apr 4, 2019

shuse2 added a commit that referenced this issue Apr 4, 2019

Merge pull request #3265 from LiskHQ/3264-revert-use-of-npm-start-docker
Revert use of "npm start" in Dockerfile and docker-compose.yml - Closes #3264

@shuse2 shuse2 closed this Apr 4, 2019

Version 1.6.0 automation moved this from To do to Done Apr 4, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.