Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove network related config from Chain module #3484

Closed
lsilvs opened this issue Apr 30, 2019 · 0 comments · Fixed by #3485
Closed

Remove network related config from Chain module #3484

lsilvs opened this issue Apr 30, 2019 · 0 comments · Fixed by #3485
Assignees
@lsilvs
Labels
type: bug

Comments

@lsilvs
Copy link
Contributor

lsilvs commented Apr 30, 2019 •
edited

Expected behavior

Expect Chain module to not use network related config.
It crashes the application when trying to run snapshotting process.

Actual behavior

It is still used in the following files:

framework/src/modules/chain/chain.js#L109
framework/src/modules/chain/submodules/peers.js#L50

Steps to reproduce

node lisk/src/index.js -n devnet -s 1

Which version(s) does this affect? (Environment, OS, etc...)

development
@lsilvs lsilvs changed the title Remove network related options from Chain module Remove network related config from Chain module Apr 30, 2019
@lsilvs lsilvs self-assigned this Apr 30, 2019
@lsilvs lsilvs mentioned this issue Apr 30, 2019
Merged
shuse2 added a commit that referenced this issue May 1, 2019
@shuse2
Merge pull request #3485 from LiskHQ/3484-remove-network-related-options
0b9dd33 
Remove network related config from Chain module - Closes #3484
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lsilvs lsilvs

Labels
type: bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove network related config from Chain module - Closes #3484 LiskHQ/lisk-sdk
1 participant
@lsilvs