Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create base class for peer list for peer directory #4048

Closed
ishantiw opened this issue Aug 6, 2019 · 0 comments · Fixed by #4160
Closed

Create base class for peer list for peer directory #4048

ishantiw opened this issue Aug 6, 2019 · 0 comments · Fixed by #4160
Assignees
@ishantiw
Labels
elements/P2P type: refactoring
Milestone
Sprint 4

Comments

@ishantiw
Copy link
Member

ishantiw commented Aug 6, 2019

Description

A lot of redundant and similar methods in new/triedPeers.

Motivation

We need a base class and new/tried Peers can extend from it.

Acceptance Criteria

All the tests related to new/Tried Peers should pass and should implement the base class method that differs.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ishantiw ishantiw

Labels
elements/P2P type: refactoring
Projects
None yet
Milestone
Sprint 4
Development

Successfully merging a pull request may close this issue.

Create base class peer list - Closes #4048 LiskHQ/lisk-sdk
2 participants
@ishantiw @sridharmeganathan