Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add unit test coverage for P2P inbound peer file #4224

Closed
diego-G opened this issue Sep 9, 2019 · 0 comments · Fixed by #4296
Closed

Add unit test coverage for P2P inbound peer file #4224

diego-G opened this issue Sep 9, 2019 · 0 comments · Fixed by #4296
Assignees
@diego-G
Labels
elements/P2P type: test
Milestone
Sprint 5 - P2P

Comments

@diego-G
Copy link

diego-G commented Sep 9, 2019

Expected behavior

Every file from lisk-p2p library is well covered with unit test. The minimum must be 80% at least to achieve green reports.

Actual behavior

peer/inbound.ts counts with only 57.14 %.

Steps to reproduce

npm t

Which version(s) does this affect? (Environment, OS, etc...)

+2.3
@diego-G diego-G added this to the Sprint 6 - P2P milestone Sep 9, 2019
@ishantiw ishantiw mentioned this issue Sep 9, 2019
Closed
11 tasks
@diego-G diego-G self-assigned this Sep 18, 2019
@diego-G diego-G mentioned this issue Sep 23, 2019
Merged
5 tasks
shuse2 added a commit that referenced this issue Sep 27, 2019
@shuse2
Merge pull request #4296 from LiskHQ/4224-add_unit_tests_p2p_inbound_…
e60bcc5 
…peer

Add unit tests for P2P Inbound peer class - Closes #4224
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@diego-G diego-G

Labels
elements/P2P type: test
Projects
None yet
Milestone
Sprint 5 - P2P
Development

Successfully merging a pull request may close this issue.

Add unit tests for P2P Inbound peer class - Closes #4224 LiskHQ/lisk-sdk
1 participant
@diego-G