Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve network actions to expose connectedPeers and disconnectedPeers #4361

Closed
ishantiw opened this issue Oct 2, 2019 · 1 comment
Closed
Assignees
Milestone

Comments

@ishantiw
Copy link
Member

ishantiw commented Oct 2, 2019

Description

Improve network actions to expose connectedPeers and disconnectedPeers

Motivation

Right now we expose getPeers and getUniqueOutboundPeers
getPeers action returns a list of all the peers with state value 0 for disconnected and 1 for connected peers but other modules usually are interested in connectedPeers and we want to get rid of state value in the future.

Also, there was an extra overhead every time we call these actions as it was going through consolidatePeers function that is used to assign state value based on connection state of peers.

Acceptance Criteria

Other modules should be able to call connectedPeer or disconnectedPeers actions without passing state filter.

@shuse2
Copy link
Member

shuse2 commented Nov 12, 2019

Superseded by #4374

@shuse2 shuse2 closed this as completed Nov 12, 2019
@sridharmeganathan sridharmeganathan added this to the Sprint 9 milestone Nov 13, 2019
@karmacoma karmacoma removed this from the Sprint 9 milestone Jan 15, 2020
@sridharmeganathan sridharmeganathan added this to the Spike 1 milestone Jan 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants