Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply penalty on sending malformed peerInfo or peerList > 1000 #4363

Closed
ishantiw opened this issue Oct 2, 2019 · 0 comments · Fixed by #4432
Closed

Apply penalty on sending malformed peerInfo or peerList > 1000 #4363

ishantiw opened this issue Oct 2, 2019 · 0 comments · Fixed by #4432
Assignees
Milestone

Comments

@ishantiw
Copy link
Member

ishantiw commented Oct 2, 2019

Description

Apply penalty on sending malformed peerInfo of some other peer or if a peer sends a peer list having more than 1000 peers.

Motivation

We want to applyPenalty when a peer sends a malformed peerInfo (more than a specific size) or when it sends a peer list more than 1000 peers so that we can stop malicious peers that constantly sending bad peers or avoid ip poisoning.

Acceptance Criteria

Add integration test where a peer sends malformed peerInfo and see if its ban score is applied by checking the ban score.

@sridharmeganathan sridharmeganathan added this to the 2019 Q4 Sprint 1 milestone Oct 16, 2019
@ishantiw ishantiw assigned ishantiw and valamidev and unassigned ishantiw Oct 17, 2019
@sridharmeganathan sridharmeganathan modified the milestones: Sprint 8, Sprint 9 Oct 30, 2019
shuse2 added a commit that referenced this issue Nov 12, 2019
Implement penalty for malformed peerList response - Closes #4363 & #4475 & #4447
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants