Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fill-pool shouldn't be called when delegate is not enabled to forge or if node is syncing #4569

Closed
ManuGowda opened this issue Nov 28, 2019 · 0 comments · Fixed by #4570
Closed

Fill-pool shouldn't be called when delegate is not enabled to forge or if node is syncing #4569

ManuGowda opened this issue Nov 28, 2019 · 0 comments · Fixed by #4570
Assignees
@ManuGowda
Labels
type: bug
Milestone
Sprint 11

Comments

@ManuGowda
Copy link
Contributor

Expected behavior

Fill-pool should be called after checking if the delegate is enabled to forge and if the node is not syncing

Actual behavior

Fill-pool is called before checking if the delegate is not enabled to forge or if the node is syncing

Steps to reproduce

Which version(s) does this affect? (Environment, OS, etc...)

3.0.0
@ManuGowda ManuGowda added this to the Sprint 11 milestone Nov 28, 2019
@ManuGowda ManuGowda self-assigned this Nov 28, 2019
@ManuGowda ManuGowda mentioned this issue Nov 28, 2019
Merged
5 tasks
ManuGowda added a commit that referenced this issue Nov 28, 2019
@ManuGowda
Merge pull request #4570 from LiskHQ/4569-bugix_forging
c5c7236 
Fill-pool shouldn't be called when delegate is not enabled to forge or if node is syncing - Closes #4569
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ManuGowda ManuGowda

Labels
type: bug
Projects
None yet
Milestone
Sprint 11
1 participant
@ManuGowda