Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update reader/writer interface to support the decode #5343

Closed
shuse2 opened this issue May 18, 2020 · 0 comments · Fixed by #5344
Closed

Update reader/writer interface to support the decode #5343

shuse2 opened this issue May 18, 2020 · 0 comments · Fixed by #5344
Assignees
@shuse2
Labels
elements/codec type: refactoring unplanned
Milestone
Sprint 19

Comments

@shuse2
Copy link
Member

shuse2 commented May 18, 2020

Description

  • Remove schema input from scalar writers, and the input should be simply value
  • Add offset parameter to the scalar readers
  • Return value and size as tuple from scalar readers

Motivation

  • Decode needs the size to be return to see how many bytes are read
  • Decode needs offset input to decide where to read from
  • Encode does decides which scalar writer to use, so schema is unnecessary input

Acceptance Criteria

  • All tests needs to be updated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shuse2 shuse2

Labels
elements/codec type: refactoring unplanned
Projects
None yet
Milestone
Sprint 19
Development

Successfully merging a pull request may close this issue.

Update scalar reader and writer LiskHQ/lisk-sdk
1 participant
@shuse2