Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lastBlockId should be type bytes #5544

Closed
shuse2 opened this issue Jul 9, 2020 · 0 comments · Fixed by #5547
Closed

lastBlockId should be type bytes #5544

shuse2 opened this issue Jul 9, 2020 · 0 comments · Fixed by #5547
Assignees
Milestone

Comments

@shuse2
Copy link
Member

shuse2 commented Jul 9, 2020

Expected behavior

lastBlockId should be named lastBlockID with type bytes and handled as bytes

Actual behavior

Currently lastBlockId propagates as node info through P2P is uint32, but it should be bytes.
Also, in the code it is treated as string.

Steps to reproduce

N/A

Which version(s) does this affect? (Environment, OS, etc...)

5.0-

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant