Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add rate limit on getLastBlock, getBlocksFromId and getHighestCommonBlock #5844

Closed
shuse2 opened this issue Oct 2, 2020 · 0 comments · Fixed by #5854
Closed

Add rate limit on getLastBlock, getBlocksFromId and getHighestCommonBlock #5844

shuse2 opened this issue Oct 2, 2020 · 0 comments · Fixed by #5854
Assignees
@ManuGowda
Labels
framework
Milestone
Sprint 29

Comments

@shuse2
Copy link
Member

shuse2 commented Oct 2, 2020 •
edited

Description

Add rate limit on 3 P2P endpoints

  • getLastBlock
  • getBlocksFromId
  • getHighestCommonBlock

using the same mechanism as getTransactions.
Since those 3 endpoints will be used by synchronisation mechanism, the rate limit should be higher.

Motivation

  • Rate limit on those 3 endpoints should be added similar to getTransactions endpoint

Acceptance Criteria

  • Run 2 nodes with 1 node syncing, and the node should not ban the another peer
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ManuGowda ManuGowda

Labels
framework
Projects
None yet
Milestone
Sprint 29
4 participants
@shuse2 @ManuGowda @ishantiw @sridharmeganathan