Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug in TransactionPool.transactionInPool - Closes #707 #1360

merged 5 commits into from Jan 23, 2018


2 participants
Copy link

commented Jan 23, 2018

What was the problem?

TransactionPool.prototype.transactionInPool returns false when transaction is in pool and have index 0 on list of indexes.

How did I fix it?

Change condition.

How to test it?

Run unit tests.


Already fixed in 1.0.0, but missing tests.

Review checklist

  • The PR solves #707
  • All new code is covered with unit tests
  • Linting passes
  • Tests pass
  • Commit messages follow the commit guidelines
  • Documentation has been added/updated

@4miners 4miners added this to Open Issues in Version 0.9.12 via automation Jan 23, 2018

@4miners 4miners requested a review from karmacoma Jan 23, 2018

@4miners 4miners added this to New Issues in Sprint Board 22-01-18 via automation Jan 23, 2018

@4miners 4miners moved this from Open Issues to Open PRs in Version 0.9.12 Jan 23, 2018

@4miners 4miners moved this from New Issues to Open PRs in Sprint Board 22-01-18 Jan 23, 2018

4miners and others added some commits Jan 23, 2018

@karmacoma karmacoma merged commit d643047 into 0.9.12 Jan 23, 2018

Version 0.9.12 automation moved this from Open PRs to Merged PRs Jan 23, 2018

Sprint Board 22-01-18 automation moved this from Open PRs to Merged PRs Jan 23, 2018

@karmacoma karmacoma deleted the 707_tx_pool_fix branch Jan 23, 2018

@SargeKhan SargeKhan referenced this pull request Mar 5, 2018


Backport 0.9.12 changes to 1.0.0 #1666

12 of 12 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.