Bug in TransactionPool.transactionInPool - Closes #707

logic/transactionPool.js

@@ -90,16 +90,19 @@ TransactionPool.prototype.bind = function (accounts, transactions, loader) {
 
 /**
  * Determines whether a transaction is in the pool based on transaction id.
+ * Checks unconfirmed, bundled, queued and multisignature lists.
  * @param {string} id - Transaction id.
- * @return {boolean} True if transaction is found in any of the indexes.
+ * @return {boolean} true If transaction id exists in at least one of indexes.
  */
 TransactionPool.prototype.transactionInPool = function (id) {
 	return [
 		self.unconfirmed.index[id],
 		self.bundled.index[id],
 		self.queued.index[id],
 		self.multisignature.index[id]
-	].filter(Boolean).length > 0;
+	].some(function (index) {
+		return typeof(index) === 'number';
+	});
 };
 
 /**

test/unit/logic/transactionPool.js

@@ -596,4 +596,99 @@ describe('transactionPool', function () {
 			});
 		});
 	});
+
+	describe('transactionInPool', function () {
+
+		afterEach(function () {
+			resetStates();
+		});
+
+		describe('when transaction is in pool', function () {
+
+			var tx = '123';
+
+			describe('unconfirmed list', function () {
+
+				describe('with index 0', function () {
+
+					it('should return true', function () {
+						transactionPool.unconfirmed.index[tx] = 0;
+						expect(transactionPool.transactionInPool(tx)).to.equal(true);
+					});
+				});
+
+				describe('with other index', function () {
+
+					it('should return true', function () {
+						transactionPool.unconfirmed.index[tx] = 1;
+						expect(transactionPool.transactionInPool(tx)).to.equal(true);
+					});
+				});
+			});
+
+			describe('bundled list', function () {
+
+				describe('with index 0', function () {
+
+					it('should return true', function () {
+						transactionPool.bundled.index[tx] = 0;
+						expect(transactionPool.transactionInPool(tx)).to.equal(true);
+					});
+				});
+
+				describe('with other index', function () {
+
+					it('should return true', function () {
+						transactionPool.bundled.index[tx] = 1;
+						expect(transactionPool.transactionInPool(tx)).to.equal(true);
+					});
+				});
+			});
+
+			describe('queued list', function () {
+
+				describe('with index 0', function () {
+
+					it('should return true', function () {
+						transactionPool.queued.index[tx] = 0;
+						expect(transactionPool.transactionInPool(tx)).to.equal(true);
+					});
+				});
+
+				describe('with other index', function () {
+
+					it('should return true', function () {
+						transactionPool.queued.index[tx] = 1;
+						expect(transactionPool.transactionInPool(tx)).to.equal(true);
+					});
+				});
+			});
+
+			describe('multisignature list', function () {
+
+				describe('with index 0', function () {
+
+					it('should return true', function () {
+						transactionPool.multisignature.index[tx] = 0;
+						expect(transactionPool.transactionInPool(tx)).to.equal(true);
+					});
+				});
+
+				describe('with other index', function () {
+
+					it('should return true', function () {
+						transactionPool.multisignature.index[tx] = 1;
+						expect(transactionPool.transactionInPool(tx)).to.equal(true);
+					});
+				});
+			});
+		});
+
+		describe('when transaction is not in pool', function () {
+
+			it('should return false', function () {
+				expect(transactionPool.transactionInPool('123')).to.equal(false);
+			});
+		});
+	});
 });