Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export storage component files through a root interface - Closes #2945 #2970

Merged
merged 4 commits into from Mar 6, 2019

Conversation

Projects
4 participants
@diego-G
Copy link
Member

commented Feb 26, 2019

Review checklist

  • The PR resolves #2945
  • All new code is covered with unit tests
  • All new code was formatted with Prettier
  • Linting passes
  • Tests pass
  • Commit messages follow the commit guidelines
  • Documentation has been added/updated

@diego-G diego-G self-assigned this Feb 26, 2019

@diego-G diego-G added this to In progress in Version 1.6.0 via automation Feb 26, 2019

@diego-G diego-G requested a review from lsilvs Feb 26, 2019

Version 1.6.0 automation moved this from In progress to Pending Review Feb 26, 2019

@diego-G diego-G force-pushed the 2766-update_transaction_entity_to_contain_just_getters branch from 9372ad9 to 4456fa5 Mar 4, 2019

@diego-G diego-G force-pushed the 2945-export_storage_files_via_interface branch from fec4cd5 to 9d92bfd Mar 4, 2019

@diego-G diego-G dismissed stale reviews from lsilvs and MaciejBaj via 9d92bfd Mar 4, 2019

@diego-G diego-G changed the base branch from 2766-update_transaction_entity_to_contain_just_getters to development Mar 4, 2019

@diego-G diego-G requested review from MaciejBaj and lsilvs and removed request for MaciejBaj Mar 4, 2019

@diego-G diego-G force-pushed the 2945-export_storage_files_via_interface branch from 9d92bfd to 7e75290 Mar 4, 2019

@diego-G diego-G requested a review from MaciejBaj Mar 4, 2019

diego-G added some commits Feb 26, 2019

@diego-G diego-G force-pushed the 2945-export_storage_files_via_interface branch from a5a7486 to b1daff5 Mar 5, 2019

@MaciejBaj MaciejBaj requested review from pablitovicente and removed request for MaciejBaj Mar 6, 2019

@pablitovicente
Copy link
Contributor

left a comment

Looks good

@lsilvs

lsilvs approved these changes Mar 6, 2019

@diego-G diego-G requested a review from MaciejBaj Mar 6, 2019

@MaciejBaj MaciejBaj merged commit 3eb0390 into development Mar 6, 2019

3 checks passed

jenkins-ci/lisk-core This commit looks good
Details
jenkins-ci/lisk-core-network This commit looks good
Details
security/snyk - package.json (LiskHQ) No manifest changes detected

Version 1.6.0 automation moved this from Pending Review to Closed PRs Mar 6, 2019

@MaciejBaj MaciejBaj deleted the 2945-export_storage_files_via_interface branch Mar 6, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.