Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove callbacks from chain module actions - Closes #2992, #3045 #3048

Merged
merged 4 commits into from Mar 12, 2019

Conversation

Projects
5 participants
@michielmulders
Copy link
Contributor

commented Mar 11, 2019

What was the problem?

No callbacks allowed in chain.js actions.

How did I fix it?

Promisify callbacks and refactor usage.

Review checklist

  • The PR resolves #3045, #2992
  • All new code is covered with unit tests
  • All new code was formatted with Prettier
  • Linting passes
  • Tests pass
  • Commit messages follow the commit guidelines
  • Documentation has been added/updated

@michielmulders michielmulders self-assigned this Mar 11, 2019

@michielmulders michielmulders added this to In progress in Version 1.6.0 via automation Mar 11, 2019

@michielmulders michielmulders requested a review from lsilvs Mar 11, 2019

Version 1.6.0 automation moved this from In progress to Pending Review Mar 11, 2019

@michielmulders michielmulders requested a review from shuse2 Mar 12, 2019

@michielmulders michielmulders changed the title Promisify getUnProcessedTransactions, getUnconfirmedTransactions and getMultisignatureTransactions Promisify getUnProcessedTransactions, getUnconfirmedTransactions and getMultisignatureTransactions - Closes #2992, #3045 Mar 12, 2019

@limiaspasdaniel limiaspasdaniel self-requested a review Mar 12, 2019

@limiaspasdaniel
Copy link
Member

left a comment

Good job with this

@lsilvs

lsilvs approved these changes Mar 12, 2019

Copy link
Member

left a comment

👍

@shuse2

shuse2 approved these changes Mar 12, 2019

_.clone(filters),
]);

const transactions = _.map(_.cloneDeep(data.transactions), transaction => {

This comment has been minimized.

Copy link
@shuse2

shuse2 Mar 12, 2019

Contributor

i would avoid using _.map but we can deal with it later because currently we have lots of places using them

This comment has been minimized.

Copy link
@limiaspasdaniel

limiaspasdaniel Mar 12, 2019

Member

Why avoiding _.map? Just being curious :D

This comment has been minimized.

Copy link
@MaciejBaj

MaciejBaj Mar 12, 2019

Member

Prefer native map

@MaciejBaj MaciejBaj changed the title Promisify getUnProcessedTransactions, getUnconfirmedTransactions and getMultisignatureTransactions - Closes #2992, #3045 Remove callbacks from chain module actions - Closes #2992, #3045 Mar 12, 2019

@MaciejBaj MaciejBaj merged commit ce16e8c into development Mar 12, 2019

3 checks passed

jenkins-ci/lisk-core This commit looks good
Details
jenkins-ci/lisk-core-network This commit looks good
Details
security/snyk - package.json (LiskHQ) No manifest changes detected

Version 1.6.0 automation moved this from Pending Review to Closed PRs Mar 12, 2019

@MaciejBaj MaciejBaj deleted the 3045-remove_callback_chain_actions branch Mar 12, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.