Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add jest tests to CI pipeline - Closes #2946 #3094

Merged
merged 8 commits into from Mar 20, 2019

Conversation

Projects
4 participants
@yatki
Copy link
Member

commented Mar 15, 2019

What was the problem?

Jest tests were not part of Jenkins

How did I fix it?

I updated Jenkinsfile

How to test it?

Review checklist

  • The PR resolves #2946
  • All new code is covered with unit tests
  • All new code was formatted with Prettier
  • Linting passes
  • Tests pass
  • Commit messages follow the commit guidelines
  • Documentation has been added/updated

@yatki yatki self-assigned this Mar 15, 2019

@yatki

This comment has been minimized.

Copy link
Member Author

commented Mar 15, 2019

This PR depends on #3078

@yatki yatki requested review from fchavant and removed request for fchavant Mar 15, 2019

michielmulders and others added some commits Mar 4, 2019

@yatki yatki force-pushed the 2946-add_jest_CI_pipeline branch from ac825dd to 68919ba Mar 18, 2019

@yatki yatki marked this pull request as ready for review Mar 18, 2019

@yatki yatki requested a review from fchavant Mar 18, 2019

@yatki yatki added this to In progress in Version 1.6.0 via automation Mar 18, 2019

Show resolved Hide resolved Jenkinsfile

Version 1.6.0 automation moved this from In progress to Pending Review Mar 18, 2019

@yatki yatki requested a review from MaciejBaj Mar 18, 2019

@MaciejBaj MaciejBaj merged commit 76bf612 into development Mar 20, 2019

3 checks passed

jenkins-ci/lisk-core This commit looks good
Details
jenkins-ci/lisk-core-network This commit looks good
Details
security/snyk - package.json (LiskHQ) No new issues
Details

Version 1.6.0 automation moved this from Pending Review to Closed PRs Mar 20, 2019

@MaciejBaj MaciejBaj deleted the 2946-add_jest_CI_pipeline branch Mar 20, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.