Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in newrelic lisk - Closes #3206 #3207

Merged
merged 1 commit into from Mar 28, 2019

Conversation

Projects
3 participants
@limiaspasdaniel
Copy link
Member

commented Mar 27, 2019

What was the problem?

components is actually written as componentes in newrelic_lisk.js

How did I fix it?

By correcting the naming of componentes to components

How to test it?

Review checklist

  • The PR resolves #3206
  • All new code is covered with unit tests
  • All new code was formatted with Prettier
  • Linting passes
  • Tests pass
  • Commit messages follow the commit guidelines
  • Documentation has been added/updated

@limiaspasdaniel limiaspasdaniel self-assigned this Mar 27, 2019

@limiaspasdaniel limiaspasdaniel requested a review from shuse2 Mar 27, 2019

@limiaspasdaniel limiaspasdaniel added this to In progress in Version 1.6.0 via automation Mar 27, 2019

@limiaspasdaniel

This comment has been minimized.

Copy link
Member Author

commented Mar 27, 2019

@diego-G I am fixing this small issue here so it's ready for 1.6

Version 1.6.0 automation moved this from In progress to Pending Review Mar 27, 2019

@shuse2

shuse2 approved these changes Mar 27, 2019

@lsilvs

lsilvs approved these changes Mar 28, 2019

@shuse2 shuse2 merged commit a9369be into 1.6.0 Mar 28, 2019

3 checks passed

jenkins-ci/lisk-core This commit looks good
Details
jenkins-ci/lisk-core-network This commit looks good
Details
security/snyk - package.json (LiskHQ) No manifest changes detected

Version 1.6.0 automation moved this from Pending Review to Closed PRs Mar 28, 2019

@shuse2 shuse2 deleted the 3206-Fix_typo_in_newrelic_lisk branch Mar 28, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.