Change protocol format and RPC procedure names to match LIP - Closes #4118 #4431
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shuse2
previously approved these changes
Oct 28, 2019
diego-G
previously approved these changes
Oct 29, 2019
shuse2
previously approved these changes
Oct 29, 2019
Applynodeinfo logic is changed and its no longer valid The appropriate test is covered in apply_node_info.ts test
Applynodeinfo logic is changed and its no longer valid The appropriate test is covered in apply_node_info.ts test
…to 4118-update-rpc-names
1) Remove unwanted sudo permission 2) Check for darwin 3) Add disable local ip script
|
The maxpayload skipped test will be fixed as part of the issue #4447 |
diego-G
approved these changes
Oct 31, 2019
shuse2
approved these changes
Oct 31, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem?
RPC endpoints were inconsistent
How did I solve it?
Updated the RPC endpoints according to standard names
How to manually test it?
npm run test
Review checklist