Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update framework folder structure - Closes #5689 #5709

Merged
merged 3 commits into from Aug 26, 2020
Merged

Update framework folder structure - Closes #5689 #5709

merged 3 commits into from Aug 26, 2020

Conversation

shuse2
Copy link
Member

@shuse2 shuse2 commented Aug 26, 2020

What was the problem?

This PR resolves #5689

How was it solved?

  • Only moving the folder structure and fixing import path

How was it tested?

All build and test should work

@shuse2 shuse2 self-assigned this Aug 26, 2020
nazarhussain
nazarhussain suggested changes Aug 26, 2020
View reviewed changes
Copy link
Contributor

@nazarhussain nazarhussain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, except few small suggestions.

  • Rename systems_dirs.ts to utils.ts
  • Merge src/controller/types.ts to src/types.ts
  • Move src/controller/constants.ts to src/constants.ts

nazarhussain
nazarhussain suggested changes Aug 26, 2020
View reviewed changes
framework/src/application.ts Outdated Show resolved Hide resolved
ManuGowda
ManuGowda reviewed Aug 26, 2020
View reviewed changes
Copy link
Contributor

@ManuGowda ManuGowda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, functional test dir structure doesn't follow new structure.

@shuse2 shuse2 mentioned this pull request Aug 26, 2020
Merged
@shuse2
Copy link
Member Author

shuse2 commented Aug 26, 2020

@ManuGowda I think it is following the structure, please recheck again.
@nazarhussain I think systems_dirs is explicit what it has. If we include more function we can consider to rename it accordingly.

@shuse2 shuse2 merged commit 58c7a94 into development Aug 26, 2020
@shuse2 shuse2 deleted the 5689-update_framework_folder branch August 26, 2020 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nazarhussain nazarhussain nazarhussain approved these changes

@ManuGowda ManuGowda ManuGowda approved these changes

Assignees

@shuse2 shuse2

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Framework folder structure should follow class structure
3 participants
@shuse2 @nazarhussain @ManuGowda