Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update LiskHQ/node-sodium version #988

Merged
merged 1 commit into from Nov 20, 2017

Conversation

2 participants
@fchavant
Copy link
Member

commented Nov 16, 2017

No description provided.

@fchavant fchavant self-assigned this Nov 16, 2017

@karmacoma karmacoma added the ready label Nov 16, 2017

@karmacoma karmacoma changed the base branch from master to 0.10.0 Nov 17, 2017

@karmacoma karmacoma added this to Pull Requests in Version 0.9.11 Nov 17, 2017

@karmacoma karmacoma added this to Open PRs in Sprint Board 13-11-17 Nov 17, 2017

@karmacoma karmacoma removed the ready label Nov 19, 2017

@karmacoma karmacoma removed this from Open PRs in Sprint Board 13-11-17 Nov 19, 2017

Jenkins failing

@karmacoma karmacoma added the failing label Nov 19, 2017

@karmacoma karmacoma added this to Open PRs in Sprint Board 20-11-17 Nov 19, 2017

@fchavant

This comment has been minimized.

Copy link
Member Author

commented Nov 20, 2017

Jenkins build is failing because bower and grunt are not installed globally on the Jenkins core nodes but are being called explicitely in the Jenkinsfile from the master branch.

@karmacoma karmacoma merged commit 676af0d into 0.10.0 Nov 20, 2017

2 checks passed

continuous-integration/jenkins/pr-merge This commit looks good
Details
coverage/coveralls First build on PR-988 at 71.088%
Details

@karmacoma karmacoma deleted the update-liskhq-node-sodium-master branch Nov 20, 2017

@karmacoma karmacoma moved this from Pull Requests to Merged Pull Requests in Version 0.9.11 Nov 20, 2017

@karmacoma karmacoma moved this from Open PRs to Merged PRs in Sprint Board 20-11-17 Nov 20, 2017

shuse2 added a commit that referenced this pull request Apr 15, 2019

Merge pull request #988 from LiskHQ/987-remove_a_getters_for_sockets_…
…in_peer_class

Remove a getters for sockets in peer class - Closes#987
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.