New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parameters propagation bug in logic/transactionspool #1015

Closed
gregorst3 opened this Issue Nov 21, 2017 · 1 comment

Comments

3 participants
@gregorst3

gregorst3 commented Nov 21, 2017

Hello Gregorst here,

I've found what seems to be a bug.

I was reading logic/transactionPool file when I encountered line 218 https://github.com/LiskHQ/lisk/blob/development/logic/transactionPool.js#L218 which calls the getMultisignatureTransactionList with three params:

  • false
  • false
  • maxTxsPerBlock

If you chcek modules/transactions the method accept only 2 params (reverse and limit) (both booleans) and immediately returns the control to logic/transactionPool.js getMultiSignatureTransactionList method which accepts indeed 3 params (reverse,ready,limit).

As an effect: limit is never propagated correctly (But that shouldn't cause any issue).

I think there was a typo when implementing the "transaction module" or when writing line 218 in logic/transactionPool.js (maybe?).

Cheers

@karmacoma karmacoma added the bug label Nov 21, 2017

@karmacoma

This comment has been minimized.

Member

karmacoma commented Nov 21, 2017

Thanks for the bug report, we will get this sorted in asap.

@karmacoma karmacoma added this to Open Issues in Version 0.9.11 Nov 21, 2017

@karmacoma karmacoma added this to News Issues in Sprint Board 20-11-17 Nov 21, 2017

@karmacoma karmacoma added the *easy label Nov 21, 2017

@karmacoma karmacoma removed this from New Issues in Sprint Board 20-11-17 Nov 24, 2017

@karmacoma karmacoma added this to Previous Issues in Sprint Board 27-11-17 Nov 24, 2017

@karmacoma karmacoma moved this from Previous Issues to New Issues in Sprint Board 27-11-17 Nov 24, 2017

@karmacoma karmacoma removed this from New Issues in Sprint Board 27-11-17 Dec 1, 2017

@karmacoma karmacoma added this to Previous Issues in Sprint Board 04-12-17 Dec 1, 2017

karmacoma added a commit that referenced this issue Dec 5, 2017

Merge pull request #1017 from LiskHQ/1015-propagate_missing_param
Fix missing parameter propagation - Closes #1015

@karmacoma karmacoma moved this from Open Issues to Closed Issues in Version 0.9.11 Dec 5, 2017

@karmacoma karmacoma closed this Dec 5, 2017

@karmacoma karmacoma moved this from Previous Issues to Closed Issues in Sprint Board 04-12-17 Dec 5, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment