New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent response for /transactions endpoint #1884

Closed
lsilvs opened this Issue Apr 16, 2018 · 2 comments

Comments

Projects
3 participants
@lsilvs

lsilvs commented Apr 16, 2018

Expected behavior

Given I make the following calls:

/transactions?blockId=:blockId&sort=timestamp:desc&offset=0&limit=51 and
/transactions?blockId=:blockId&sort=timestamp:desc&offset=50&limit=51

I expect the last item returned by the first call to be the same as the first item returned by the second call.

Actual behavior

It is not.

Steps to reproduce

Using the following test database:

Compare the first call with the second call

Which version(s) does this affect? (Environment, OS, etc...)

v1.0.0-beta.5

@diego-G

This comment has been minimized.

Show comment
Hide comment
@diego-G

diego-G Apr 26, 2018

Member

Your calls are getting transactions with timestamp 0. What we need is a second default sort parameter as a tiebreaker.

Member

diego-G commented Apr 26, 2018

Your calls are getting transactions with timestamp 0. What we need is a second default sort parameter as a tiebreaker.

@diego-G diego-G self-assigned this Apr 26, 2018

@diego-G diego-G added this to Open Issues in Version 1.0.0 via automation Apr 26, 2018

@diego-G diego-G added this to New Issues in Sprint Board 23-04-18 via automation Apr 26, 2018

@diego-G diego-G added this to the Version 1.0.0-beta.8 milestone Apr 26, 2018

@diego-G diego-G assigned Tschakki and unassigned diego-G Apr 26, 2018

@lsilvs

This comment has been minimized.

Show comment
Hide comment
@lsilvs

lsilvs Apr 26, 2018

Maybe it's a good idea to introduce this second default sort for all endpoints that have sorting option.

lsilvs commented Apr 26, 2018

Maybe it's a good idea to introduce this second default sort for all endpoints that have sorting option.

@MaciejBaj MaciejBaj closed this in 5949624 May 5, 2018

Version 1.0.0 automation moved this from Open Issues to Closed Issues May 5, 2018

Sprint Board 23-04-18 automation moved this from New Issues to Closed Issues May 5, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment