Skip to content
This repository has been archived by the owner on Jun 11, 2024. It is now read-only.

Log level of "Inserted new peer" and "Removed peer" should be symmetric #1992

Closed
webmaster128 opened this issue May 3, 2018 · 0 comments
Closed

Log level of "Inserted new peer" and "Removed peer" should be symmetric #1992

webmaster128 opened this issue May 3, 2018 · 0 comments
Assignees
@jondubois
Labels
elements/P2P
Milestone
Version 1.1.0

Comments

@webmaster128
Copy link
Contributor

webmaster128 commented May 3, 2018 •
edited
Loading

Expected behavior

Log level of "Inserted new peer" and "Removed peer" should be symmetric

I think the "Removed peer" logs are too spammy for a default info configuration and should be log level debug.

Actual behavior

  • "Inserted new peer" logs are created for log level debug
  • "Removed peer" logs are created for log level info

Steps to reproduce

Watch the logs in the default configuration ("fileLogLevel": "info"). As you can see, there are always peers removed (but never added according to the logs).

Which version(s) does this affect? (Environment, OS, etc...)

0.9.14a
@karmacoma karmacoma added the logs label May 20, 2018
@MaciejBaj MaciejBaj added this to the Version 1.1.0 milestone Jun 20, 2018
@MaciejBaj MaciejBaj modified the milestones: Version 1.1.0, Version 1.2.0 Jul 4, 2018
@jondubois jondubois mentioned this issue Jul 10, 2018
Merged
MaciejBaj added a commit that referenced this issue Jul 13, 2018
@MaciejBaj
Merge pull request #2215 from LiskHQ/1992-log_level_asymmetric
75cc90a 
Log level of "Inserted new peer" and "Removed peer" should be symmetric - Closes #1992
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jondubois jondubois

Labels
elements/P2P
Projects
None yet
Milestone
Version 1.1.0
Development

No branches or pull requests
4 participants
@karmacoma @jondubois @webmaster128 @MaciejBaj