Block propagation failure/partition and node crash

[jondubois]

Expected behavior

Blocks should propagate across the network.
Also, if the socket is no longer attached to a peer object, then we should not call emit on that socket.

Actual behavior

There was a fork in the latest betanet because some blocks were not reaching some nodes. We thought it was a broadhash broadcasting issue initially but it appears be related to this issue LiskArchive/wamp-socket-cluster#35

Steps to reproduce

Run on latest code on betanet with 250 nodes.

Which version(s) does this affect? (Environment, OS, etc...)

Beta 7.4

[jondubois]

After several rounds of beta testing, this issue has been broken down into smaller chunks:

• Broadcast, FindGoodPeer and Broadcast header does not select intended peers #2042
• Application gets stuck when deleting last block of the same round twice #2032
• Undo on transactions called with wrong block #2037

Note that #2025 has been abandoned in favour of #2042 above.