Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send back better error when disconnecting because of invalid peer headers #2068

Closed
jondubois opened this issue May 28, 2018 · 0 comments
Closed

Comments

@jondubois
Copy link
Contributor

jondubois commented May 28, 2018

Expected behavior

If a peer tries to connect with missing required header fields, a node should send back a descriptive error message.

Actual behavior

If a peer tries to connect to us with missing headers, we disconnect them with a generic 'BadConnectionError'.
This generic error is useful for rejecting malicious peers (as not to give away too much info) but it's not ideal in this case.

See #2064 (diff)

Steps to reproduce

Try to connect to a node with missing headers as part of the WebSocket connection query string.

Which version(s) does this affect? (Environment, OS, etc...)

1.0.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants