New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use DNS name instead of IP addresses for seed nodes in config.json #2320

Closed
fchavant opened this Issue Aug 16, 2018 · 1 comment

Comments

@fchavant
Member

fchavant commented Aug 16, 2018

Expected behavior

config.json uses DNS name for seed nodes.
Rationale: DNS names give us more flexibility and are not bound to a particular service provider.

Actual behavior

IP addresses are being used.

Steps to reproduce

Look at https://github.com/LiskHQ/lisk/blob/1.2.0/config/mainnet/config.json#L10

Which version(s) does this affect? (Environment, OS, etc...)

All versions of lisk core up until now.

@jondubois

This comment has been minimized.

Show comment
Hide comment
@jondubois

jondubois Aug 20, 2018

Contributor

I created a new PR #2325 and cherry-picked the commits from this PR so we could potentially close this PR and use the other one instead (they both reference the same issue number).

Contributor

jondubois commented Aug 20, 2018

I created a new PR #2325 and cherry-picked the commits from this PR so we could potentially close this PR and use the other one instead (they both reference the same issue number).

MaciejBaj added a commit that referenced this issue Aug 21, 2018

Merge pull request #2325 from LiskHQ/2320-domain_name_instead_of_ip
Use DNS name instead of IP addresses for seed nodes in config.json - Closes #2320

@diego-G diego-G closed this Aug 21, 2018

Version 1.2.0 automation moved this from New Issues to Closed Issues Aug 21, 2018

@MaciejBaj MaciejBaj added the *medium label Aug 22, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment