New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust docker template to Mainnet #2336

Closed
MaciejBaj opened this Issue Aug 24, 2018 · 1 comment

Comments

Projects
1 participant
@MaciejBaj
Member

MaciejBaj commented Aug 24, 2018

Expected behavior

Docker configuration should be equal to the one used by v1.0.0 sources and builds.

Actual behavior

Docker configuration (contains 3 flaws: https://github.com/LiskHQ/lisk/blob/1.0.0/docker_files/etc/confd/templates/config.json.tmpl)

  1. Doesn't contain SSL configuration in api section (introduced in #2154)
  2. Contains wrong wsPorts (8000 instead of 8001)
  3. Contains wrong broadcastLimit and relaysLimit (introduced in #2077)

Steps to reproduce

Run docker image.

Which version(s) does this affect? (Environment, OS, etc...)

v1.0.0

@MaciejBaj MaciejBaj self-assigned this Aug 24, 2018

@diego-G diego-G added this to Sprint Candidate in Lisk Pipelines Aug 24, 2018

@diego-G diego-G removed this from Sprint Candidate in Lisk Pipelines Aug 24, 2018

@MaciejBaj MaciejBaj added this to Open Issues in Version 1.0.0 via automation Aug 25, 2018

@MaciejBaj

This comment has been minimized.

Show comment
Hide comment
@MaciejBaj

MaciejBaj Aug 25, 2018

Member

Closed by 47908d6.

Member

MaciejBaj commented Aug 25, 2018

Closed by 47908d6.

@MaciejBaj MaciejBaj closed this Aug 25, 2018

Version 1.0.0 automation moved this from Open Issues to Closed Issues Aug 25, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment