Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong amount check in verify function of logic/In_transfer and logic/out_transfer #2430

Closed
ManuGowda opened this Issue Oct 1, 2018 · 0 comments

Comments

Projects
3 participants
@ManuGowda
Copy link
Member

ManuGowda commented Oct 1, 2018

Expected behavior

InTransfer and OutTransfer verify function should check if amount.equals(0)

Actual behavior

InTransfer verify function checks if the transaction amount is not equals zero

if (!amount.equals(0)) {

OutTransfer verify function checks if the transaction amount is not equals zero
if (!amount.equals(0)) {

Steps to reproduce

Which version(s) does this affect? (Environment, OS, etc...)

1.1.0

@nazarhussain nazarhussain self-assigned this Oct 1, 2018

@nazarhussain nazarhussain added this to New Issues in Version 1.1.0 via automation Oct 1, 2018

@nazarhussain nazarhussain added this to the Version 1.1.0 milestone Oct 2, 2018

MaciejBaj added a commit that referenced this issue Oct 4, 2018

Merge pull request #2432 from LiskHQ/2430-amount-fix
Wrong amount check in verify function of logic/In_transfer and logic/out_transfer - Closes #2430

@MaciejBaj MaciejBaj closed this Oct 4, 2018

Version 1.1.0 automation moved this from New Issues to Closed Issues Oct 4, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.