Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change of vote processing logic ignore address collision scenario #2434

Closed
nazarhussain opened this Issue Oct 4, 2018 · 0 comments

Comments

Projects
4 participants
@nazarhussain
Copy link
Contributor

nazarhussain commented Oct 4, 2018

Expected behavior

The votes processing should be done against the publicKeys to avoid any address collision. Like the way it was implemented in the 1.0.0

Actual behavior

With some changes introduced in PR #2189, we change the vote processing logic to be used on address. Which identifies that we have few address collisions on both networks.

So votes casted for different public key result into same address (in collision case), and cause error `already casted votes.

Few sample are to verify the issue on testnet.

b26dd40ba33e4785e49ddc4f106c0493ed00695817235c778f487aea5866400a, ce33db918b059a6e99c402963b42cf51c695068007ef01d8c383bb8a41270263

Few sample are to verify the issue on mainnet.

ce3d5baae39cce28d1fa8b41ab1ebac69473a1ad38d5caf9184d6c58c081447c, aaf8c168739eb5aa7e923bbdbe9c5a7a07c77a487629df8fe1da608df5f96cec

Steps to reproduce

Sync form the network with 1.1.0.

Which version(s) does this affect? (Environment, OS, etc...)

1.1.0

@nazarhussain nazarhussain added this to the Version 1.1.0 milestone Oct 4, 2018

@nazarhussain nazarhussain added this to New Issues in Version 1.1.0 via automation Oct 4, 2018

MaciejBaj added a commit that referenced this issue Oct 5, 2018

Merge pull request #2442 from LiskHQ/2434-votes_collision
Add fix for vote collision scenario - Closes #2434

@MaciejBaj MaciejBaj added this to Sprint Backlog in Lisk Pipelines Oct 5, 2018

@MaciejBaj MaciejBaj closed this Oct 5, 2018

Version 1.1.0 automation moved this from New Issues to Closed Issues Oct 5, 2018

@MaciejBaj MaciejBaj removed this from Sprint Backlog in Lisk Pipelines Oct 5, 2018

@SargeKhan SargeKhan reopened this Oct 8, 2018

MaciejBaj added a commit that referenced this issue Oct 8, 2018

Merge pull request #2448 from LiskHQ/2434-votes_collision
Add exception for votes collision for testnet - Closes #2434

@karmacoma karmacoma closed this Oct 9, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.