Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use a consistent and informative versioning scheme #2594

Closed
MaciejBaj opened this issue Nov 28, 2018 · 0 comments · Fixed by #2751
Closed

Use a consistent and informative versioning scheme #2594

MaciejBaj opened this issue Nov 28, 2018 · 0 comments · Fixed by #2751
Assignees
@2snEM6
Labels
framework type: docs
Milestone
Use a consistent ...

Comments

@MaciejBaj
Copy link
Contributor

Expected behavior

Follow the implementation guidelines of LIP:

  • Rely on protocolVersion field to determine compatibility between two nodes.
  • Keep the backwards compatibility by preserving the check relying on minVersion.
  • Start from protocolVersion equal 1.0.

Actual behavior

In the handshake process, the "minVersion" field is currently used to determine compatibility between two nodes.

Which version(s) does this affect? (Environment, OS, etc...)

*
@diego-G diego-G removed their assignment Dec 19, 2018
@2snEM6 2snEM6 self-assigned this Jan 7, 2019
@diego-G diego-G pinned this issue Jan 7, 2019
@diego-G diego-G unpinned this issue Jan 7, 2019
@MaciejBaj MaciejBaj added the *hard label Jan 9, 2019
@Tschakki Tschakki mentioned this issue Jan 15, 2019
Closed
@2snEM6 2snEM6 mentioned this issue Jan 17, 2019
Merged
MaciejBaj added a commit that referenced this issue Jan 28, 2019
@MaciejBaj
Merge pull request #2751 from LiskHQ/2594_Use_consistent_informative_…
bd243ba 
…versioning_scheme

Use consistent informative versioning scheme - Closes #2594
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@2snEM6 2snEM6

Labels
framework type: docs
Projects
None yet
Milestone
Use a consistent and informative vers...
Development

Successfully merging a pull request may close this issue.

Use consistent informative versioning scheme - Closes #2594 LiskHQ/lisk-sdk
3 participants
@diego-G @MaciejBaj @2snEM6