Rename fromTimestamp and toTimestamp of the /api/transactions endpoint #431

Closed
simonmorgenthaler opened this Issue Feb 9, 2017 · 0 comments

Comments

Projects
None yet
3 participants
@simonmorgenthaler

The /api/transactions endpoint can now be used with 'fromTimestamp' and 'toTimestamp'. But those parameters expect unix timestamps, not the timestamps that are included in the transaction. This is confusing.

I suggest the following:

rename fromTimestamp -> fromUnitTimestamp and toTimestamp -> toUnixTimestamp

@4miners 4miners added the enhancement label Feb 9, 2017

@4miners 4miners self-assigned this Feb 9, 2017

@karmacoma karmacoma added this to Ready in Version 0.7.0 Feb 10, 2017

@karmacoma karmacoma added the *easy label Feb 10, 2017

@4miners 4miners added the ready label Feb 21, 2017

@karmacoma karmacoma moved this from Ready to In Progress in Version 0.7.0 Feb 22, 2017

@karmacoma karmacoma changed the title from renaming fromTimestamp and toTimestamp of the /api/transactions endpoint to Rename fromTimestamp and toTimestamp of the /api/transactions endpoint Feb 22, 2017

@karmacoma karmacoma closed this in #438 Feb 23, 2017

karmacoma added a commit that referenced this issue Feb 23, 2017

Merge pull request #438 from 4miners/431-432_transactions-endpoint
Improve /api/transactions endpoint. Closes #431. Closes #432.

@karmacoma karmacoma removed this from In Progress in Version 0.7.0 Feb 23, 2017

@karmacoma karmacoma removed the ready label Feb 23, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment