Round arithmetic is using standard Math functions #447

Closed
karmacoma opened this Issue Feb 23, 2017 · 2 comments

Comments

Projects
None yet
2 participants
@karmacoma
Member

karmacoma commented Feb 23, 2017

For reliable number accuracy and consistency with the rest of application, all math operations such as floor, ceil, addition, subtraction should be conducted using the bignum.js: https://github.com/LiskHQ/lisk/blob/development/helpers/bignum.js.

Affected modules:

@karmacoma karmacoma added the bug label Feb 23, 2017

@karmacoma karmacoma added this to the Version 0.7.0 milestone Feb 23, 2017

@karmacoma karmacoma added this to Ready in Version 0.7.0 Feb 23, 2017

@karmacoma karmacoma moved this from Ready to In Progress in Version 0.7.0 Feb 23, 2017

@karmacoma karmacoma added the *medium label Feb 23, 2017

@karmacoma

This comment has been minimized.

Show comment
Hide comment
@karmacoma

karmacoma Feb 23, 2017

Member

@MaciejBaj: Please start with unit tests against existing round logic. Adding failing context for potential number accuracy problem. Then make code changes. Thanks.

Member

karmacoma commented Feb 23, 2017

@MaciejBaj: Please start with unit tests against existing round logic. Adding failing context for potential number accuracy problem. Then make code changes. Thanks.

@karmacoma

This comment has been minimized.

Show comment
Hide comment
@karmacoma

karmacoma Feb 23, 2017

Member

@MaciejBaj: Once we've proven through unit tests, it might require rebuilding of memory tables. This we also need check.

Member

karmacoma commented Feb 23, 2017

@MaciejBaj: Once we've proven through unit tests, it might require rebuilding of memory tables. This we also need check.

@4miners 4miners referenced this issue Feb 27, 2017

Closed

Improve blocks processing efficiency #449

4 of 4 tasks complete

@karmacoma karmacoma closed this in #450 Mar 2, 2017

karmacoma added a commit that referenced this issue Mar 2, 2017

Merge pull request #450 from MaciejBaj/447-round-bignum
BigNumber in round calculations - Closes #447

@karmacoma karmacoma removed this from In Progress in Version 0.7.0 Mar 2, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment