Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unnecessary webSocket config parameter appName - Closes #2720 #2721

Merged
merged 1 commit into from Jan 9, 2019
Merged

Remove unnecessary webSocket config parameter appName - Closes #2720 #2721

merged 1 commit into from Jan 9, 2019

Conversation

diego-G
Copy link

@diego-G diego-G commented Jan 9, 2019

How to test it?

Trigger any network test scenario and check if logs from every peer is showing the error mentioned in the issue.
npm test -- mocha:propagation:network

Review checklist

@diego-G diego-G self-assigned this Jan 9, 2019
@MaciejBaj MaciejBaj merged commit bdc951a into development Jan 9, 2019
@MaciejBaj MaciejBaj deleted the 2720-fix_scBroker_error_initiating_application branch January 9, 2019 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MaciejBaj MaciejBaj MaciejBaj approved these changes

@jondubois jondubois Awaiting requested review from jondubois

Assignees

@diego-G diego-G

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

scBroker sever throws error when launching a network with several peers
2 participants
@diego-G @MaciejBaj