Upgrade dependencies January 2019 - Related to #2500 #2732
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Taking into account how massive the code changes are - 60k changed line, we should suspend accepting the PR until the DB feature (https://github.com/LiskHQ/lisk/tree/feature/extensible-data-persistence-model) branch gets merged into |
|
@MaciejBaj I understand your concerns. I can remove |
Breaking changes are in `toFraction`, `BigNumber.min` & `BigNumber.max` functions that are not used in our codebase.
spy.reset() was deprecated, so we use spy.resetHistory() from now on
diego-G
force-pushed
the
2500-update_dependencies_january_2019
branch
from
9c86a4e
to
499e577
Compare
MaciejBaj
previously approved these changes
Jan 14, 2019
MaciejBaj
approved these changes
Jan 16, 2019
lsilvs
pushed a commit
that referenced
this pull request
Jan 30, 2019
lsilvs
added a commit
that referenced
this pull request
Jan 30, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Review checklist