Add genesis block loading progress logger - Closes #290 #440

Merged
merged 5 commits into from Feb 24, 2017

Conversation

Projects
5 participants
@MaciejBaj
Member

MaciejBaj commented Feb 16, 2017

log applying transactions progress while loading genesis block.
closes #290

@MaciejBaj

This comment has been minimized.

Show comment
Hide comment
@MaciejBaj

MaciejBaj Feb 16, 2017

Member

it is possible to use also some cool looking stuff like https://www.npmjs.com/package/node-progress-bars, but for just info purposes I think it's enough

Member

MaciejBaj commented Feb 16, 2017

it is possible to use also some cool looking stuff like https://www.npmjs.com/package/node-progress-bars, but for just info purposes I think it's enough

@Isabello

This comment has been minimized.

Show comment
Hide comment
@Isabello

Isabello Feb 16, 2017

Contributor

As much as i like progress bars, I'm not sure how well it would display since we just fork into the background.

Contributor

Isabello commented Feb 16, 2017

As much as i like progress bars, I'm not sure how well it would display since we just fork into the background.

modules/blocks.js
+ * @param {String} msg
+ * @return {BlockApplicationLogger}
+ */
+Blocks.prototype.getBlockApplicationLogger = function (transactionsCount, logsFrequency, msg) {

This comment has been minimized.

@4miners

4miners Feb 17, 2017

Member

I don't like getBlockApplicationLogger name, maybe blockProgressLogger?

@4miners

4miners Feb 17, 2017

Member

I don't like getBlockApplicationLogger name, maybe blockProgressLogger?

@karmacoma karmacoma changed the title from add genesis block loading progress logger to Add genesis block loading progress logger Feb 17, 2017

@karmacoma karmacoma self-assigned this Feb 17, 2017

@karmacoma karmacoma added this to Pending Review in Version 0.7.0 Feb 17, 2017

add genesis block loading progress logger
log applying transactions progress while loading genesis block.
closes #290

karmacoma added some commits Feb 24, 2017

@karmacoma karmacoma changed the title from Add genesis block loading progress logger to Add genesis block loading progress logger - Closes #290 Feb 24, 2017

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Feb 24, 2017

Coverage Status

Coverage increased (+1.2%) to 64.869% when pulling 2a39910 on MaciejBaj:290-genesis-loading-progress into 9ca66db on LiskHQ:development.

coveralls commented Feb 24, 2017

Coverage Status

Coverage increased (+1.2%) to 64.869% when pulling 2a39910 on MaciejBaj:290-genesis-loading-progress into 9ca66db on LiskHQ:development.

@karmacoma karmacoma merged commit dd51e5a into LiskHQ:development Feb 24, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+1.2%) to 64.869%
Details

@karmacoma karmacoma deleted the MaciejBaj:290-genesis-loading-progress branch Feb 24, 2017

@karmacoma karmacoma moved this from Pending Review to Done in Version 0.7.0 Feb 24, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment