BigNumber in round calculations - Closes #447 #450

Merged
merged 8 commits into from Mar 2, 2017

Conversation

Projects
3 participants
@MaciejBaj
Member

MaciejBaj commented Feb 27, 2017

Update library BigNumber from 1.3 to 4.0 version. Main changes:

  • Support for NaN and Infinity
  • Always create BigNumber values with new keyword

Change the way of how bignum.js is used- install bignumber.js as npm dependency and extend it in the separate file.

Closes #447

@karmacoma karmacoma added the bug label Feb 27, 2017

@karmacoma karmacoma self-assigned this Feb 27, 2017

@karmacoma karmacoma added this to Pending Review in Version 0.7.0 Feb 27, 2017

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Feb 27, 2017

Coverage Status

Coverage increased (+3.6%) to 68.464% when pulling b453586 on MaciejBaj:447-round-bignum into dd51e5a on LiskHQ:development.

coveralls commented Feb 27, 2017

Coverage Status

Coverage increased (+3.6%) to 68.464% when pulling b453586 on MaciejBaj:447-round-bignum into dd51e5a on LiskHQ:development.

@karmacoma karmacoma changed the title from BigNumber in round calculations to BigNumber in round calculations - Closes #447 Feb 27, 2017

karmacoma added some commits Feb 28, 2017

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Feb 28, 2017

Coverage Status

Coverage increased (+3.7%) to 68.581% when pulling 7215f99 on MaciejBaj:447-round-bignum into dd51e5a on LiskHQ:development.

coveralls commented Feb 28, 2017

Coverage Status

Coverage increased (+3.7%) to 68.581% when pulling 7215f99 on MaciejBaj:447-round-bignum into dd51e5a on LiskHQ:development.

karmacoma added some commits Feb 28, 2017

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Feb 28, 2017

Coverage Status

Coverage decreased (-5.7%) to 59.21% when pulling 4720061 on MaciejBaj:447-round-bignum into dd51e5a on LiskHQ:development.

coveralls commented Feb 28, 2017

Coverage Status

Coverage decreased (-5.7%) to 59.21% when pulling 4720061 on MaciejBaj:447-round-bignum into dd51e5a on LiskHQ:development.

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Feb 28, 2017

Coverage Status

Coverage decreased (-5.7%) to 59.21% when pulling 4720061 on MaciejBaj:447-round-bignum into dd51e5a on LiskHQ:development.

Coverage Status

Coverage decreased (-5.7%) to 59.21% when pulling 4720061 on MaciejBaj:447-round-bignum into dd51e5a on LiskHQ:development.

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Feb 28, 2017

Coverage Status

Coverage decreased (-5.7%) to 59.21% when pulling 4720061 on MaciejBaj:447-round-bignum into dd51e5a on LiskHQ:development.

Coverage Status

Coverage decreased (-5.7%) to 59.21% when pulling 4720061 on MaciejBaj:447-round-bignum into dd51e5a on LiskHQ:development.

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Feb 28, 2017

Coverage Status

Coverage decreased (-5.7%) to 59.21% when pulling 4720061 on MaciejBaj:447-round-bignum into dd51e5a on LiskHQ:development.

Coverage Status

Coverage decreased (-5.7%) to 59.21% when pulling 4720061 on MaciejBaj:447-round-bignum into dd51e5a on LiskHQ:development.

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Feb 28, 2017

Coverage Status

Coverage decreased (-5.7%) to 59.21% when pulling 4720061 on MaciejBaj:447-round-bignum into dd51e5a on LiskHQ:development.

Coverage Status

Coverage decreased (-5.7%) to 59.21% when pulling 4720061 on MaciejBaj:447-round-bignum into dd51e5a on LiskHQ:development.

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Feb 28, 2017

Coverage Status

Coverage decreased (-5.7%) to 59.21% when pulling 4720061 on MaciejBaj:447-round-bignum into dd51e5a on LiskHQ:development.

Coverage Status

Coverage decreased (-5.7%) to 59.21% when pulling 4720061 on MaciejBaj:447-round-bignum into dd51e5a on LiskHQ:development.

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Feb 28, 2017

Coverage Status

Coverage decreased (-5.7%) to 59.21% when pulling 4720061 on MaciejBaj:447-round-bignum into dd51e5a on LiskHQ:development.

Coverage Status

Coverage decreased (-5.7%) to 59.21% when pulling 4720061 on MaciejBaj:447-round-bignum into dd51e5a on LiskHQ:development.

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Feb 28, 2017

Coverage Status

Coverage decreased (-5.7%) to 59.21% when pulling 4720061 on MaciejBaj:447-round-bignum into dd51e5a on LiskHQ:development.

Coverage Status

Coverage decreased (-5.7%) to 59.21% when pulling 4720061 on MaciejBaj:447-round-bignum into dd51e5a on LiskHQ:development.

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Feb 28, 2017

Coverage Status

Coverage decreased (-5.7%) to 59.21% when pulling 4720061 on MaciejBaj:447-round-bignum into dd51e5a on LiskHQ:development.

Coverage Status

Coverage decreased (-5.7%) to 59.21% when pulling 4720061 on MaciejBaj:447-round-bignum into dd51e5a on LiskHQ:development.

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Feb 28, 2017

Coverage Status

Coverage decreased (-5.7%) to 59.21% when pulling 4720061 on MaciejBaj:447-round-bignum into dd51e5a on LiskHQ:development.

Coverage Status

Coverage decreased (-5.7%) to 59.21% when pulling 4720061 on MaciejBaj:447-round-bignum into dd51e5a on LiskHQ:development.

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Feb 28, 2017

Coverage Status

Coverage increased (+2.6%) to 67.502% when pulling 9efd775 on MaciejBaj:447-round-bignum into dd51e5a on LiskHQ:development.

coveralls commented Feb 28, 2017

Coverage Status

Coverage increased (+2.6%) to 67.502% when pulling 9efd775 on MaciejBaj:447-round-bignum into dd51e5a on LiskHQ:development.

Refactoring tests
- Reviewing example descriptions.
- Testing examples against valid scope.
@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Mar 2, 2017

Coverage Status

Coverage decreased (-5.2%) to 59.706% when pulling e84c59c on MaciejBaj:447-round-bignum into dd51e5a on LiskHQ:development.

coveralls commented Mar 2, 2017

Coverage Status

Coverage decreased (-5.2%) to 59.706% when pulling e84c59c on MaciejBaj:447-round-bignum into dd51e5a on LiskHQ:development.

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Mar 2, 2017

Coverage Status

Coverage decreased (-5.2%) to 59.706% when pulling e84c59c on MaciejBaj:447-round-bignum into dd51e5a on LiskHQ:development.

Coverage Status

Coverage decreased (-5.2%) to 59.706% when pulling e84c59c on MaciejBaj:447-round-bignum into dd51e5a on LiskHQ:development.

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Mar 2, 2017

Coverage Status

Coverage decreased (-5.2%) to 59.706% when pulling e84c59c on MaciejBaj:447-round-bignum into dd51e5a on LiskHQ:development.

Coverage Status

Coverage decreased (-5.2%) to 59.706% when pulling e84c59c on MaciejBaj:447-round-bignum into dd51e5a on LiskHQ:development.

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Mar 2, 2017

Coverage Status

Coverage decreased (-5.2%) to 59.706% when pulling e84c59c on MaciejBaj:447-round-bignum into dd51e5a on LiskHQ:development.

Coverage Status

Coverage decreased (-5.2%) to 59.706% when pulling e84c59c on MaciejBaj:447-round-bignum into dd51e5a on LiskHQ:development.

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Mar 2, 2017

Coverage Status

Coverage decreased (-5.2%) to 59.706% when pulling e84c59c on MaciejBaj:447-round-bignum into dd51e5a on LiskHQ:development.

Coverage Status

Coverage decreased (-5.2%) to 59.706% when pulling e84c59c on MaciejBaj:447-round-bignum into dd51e5a on LiskHQ:development.

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Mar 2, 2017

Coverage Status

Coverage decreased (-5.2%) to 59.706% when pulling e84c59c on MaciejBaj:447-round-bignum into dd51e5a on LiskHQ:development.

Coverage Status

Coverage decreased (-5.2%) to 59.706% when pulling e84c59c on MaciejBaj:447-round-bignum into dd51e5a on LiskHQ:development.

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Mar 2, 2017

Coverage Status

Coverage decreased (-5.2%) to 59.706% when pulling e84c59c on MaciejBaj:447-round-bignum into dd51e5a on LiskHQ:development.

Coverage Status

Coverage decreased (-5.2%) to 59.706% when pulling e84c59c on MaciejBaj:447-round-bignum into dd51e5a on LiskHQ:development.

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Mar 2, 2017

Coverage Status

Coverage decreased (-5.2%) to 59.706% when pulling e84c59c on MaciejBaj:447-round-bignum into dd51e5a on LiskHQ:development.

Coverage Status

Coverage decreased (-5.2%) to 59.706% when pulling e84c59c on MaciejBaj:447-round-bignum into dd51e5a on LiskHQ:development.

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Mar 2, 2017

Coverage Status

Coverage decreased (-4.8%) to 60.07% when pulling e84c59c on MaciejBaj:447-round-bignum into dd51e5a on LiskHQ:development.

coveralls commented Mar 2, 2017

Coverage Status

Coverage decreased (-4.8%) to 60.07% when pulling e84c59c on MaciejBaj:447-round-bignum into dd51e5a on LiskHQ:development.

@karmacoma karmacoma merged commit 498dac2 into LiskHQ:development Mar 2, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+3.6%) to 68.508%
Details

@karmacoma karmacoma deleted the MaciejBaj:447-round-bignum branch Mar 2, 2017

@karmacoma karmacoma moved this from Pending Review to Done in Version 0.7.0 Mar 2, 2017

@karmacoma karmacoma removed the bug label Aug 15, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment