Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Adds option to Remember Me for a long time #237

Merged
merged 5 commits into from
Dec 1, 2021

Conversation

Lissy93
Copy link
Owner

@Lissy93 Lissy93 commented Sep 19, 2021

✨ Feature Quick Lissy93 /FEATURE/login-remember-me-always → Lissy93/dashy Commits: 5 | Files Changed: 4 | Additions: 3

Category: Feature

Overview
Just adds a new option to the Remember Me dropdown menu in the Login field, that will expire a long time in the future.

Issue Number #236 #64

New Vars N/A

Screenshot

Code Quality Checklist (Please complete)

  • All changes are backwards compatible
  • All lint checks and tests are passing
  • There are no (new) build warnings or errors
  • (If a new config option is added) Attribute is outlined in the schema and documented
  • (If a new dependency is added) Package is essential, and has been checked out for security or performance
  • Bumps version, if new feature added

@netlify
Copy link

netlify bot commented Sep 19, 2021

✔️ Deploy Preview for dashy-dev ready!

🔨 Explore the source changes: f5f49aa

🔍 Inspect the deploy log: https://app.netlify.com/sites/dashy-dev/deploys/61a7ea67d374140007eef7c0

😎 Browse the preview: https://deploy-preview-237--dashy-dev.netlify.app/

@liss-bot
Copy link
Collaborator

Hi Lissy93! Thank you for contributing to Dashy! ✨

Thank you for contributing to Dashy's translations 💖


I'm a bot, and this is an automated comment 🤖

@viezly
Copy link

viezly bot commented Sep 19, 2021

Changes preview:

Legend:

👀 Review pull request on Viezly

@Lissy93 Lissy93 added the ✨ New Feature [PR] Contains implementation of a new feature label Sep 19, 2021
@liss-bot liss-bot added the 🚫 Merge Conflicts [PR] Submitted code needs rebasing label Oct 5, 2021
@Lissy93 Lissy93 closed this Oct 31, 2021
@Lissy93 Lissy93 reopened this Dec 1, 2021
@Lissy93 Lissy93 removed the 🚫 Merge Conflicts [PR] Submitted code needs rebasing label Dec 1, 2021
@Lissy93 Lissy93 merged commit 46c413a into master Dec 1, 2021
@Lissy93 Lissy93 deleted the FEATURE/login-remember-me-always branch December 1, 2021 21:38
asterling8516 pushed a commit to asterling8516/dashy that referenced this pull request Nov 23, 2023
Closes Lissy93#237

Signed-off-by: Bjorn Lammers <walkxnl@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ New Feature [PR] Contains implementation of a new feature 🟩 PR - Small
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants