Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix byte,short underlying Enum Write issue #124

Merged
merged 1 commit into from Jan 21, 2021
Merged

Conversation

kdw9502
Copy link
Contributor

@kdw9502 kdw9502 commented Dec 17, 2020

I found that deserializing byte underying enum throw System.InvalidCastException.

Fixed it and add test for it.

@devlead devlead changed the base branch from master to develop January 21, 2021 09:44
Copy link
Member

@devlead devlead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

I've retarget PR against develop.

@devlead devlead merged commit 62a43f7 into LitJSON:develop Jan 21, 2021
@devlead
Copy link
Member

devlead commented Jan 21, 2021

@kdw9502 your changes have been merged, thanks for your contribution 👍

@devlead
Copy link
Member

devlead commented Jan 21, 2021

This is released in 0.17.0
https://www.nuget.org/packages/LitJson/0.17.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants