From 735b641328abc81279af9d09f7543105299dfa89 Mon Sep 17 00:00:00 2001 From: LiteObject Date: Thu, 22 May 2025 21:09:38 -0500 Subject: [PATCH 1/2] Fix echo statement in Generate Diff step to include 'origin/' prefix for clarity --- .github/workflows/code-review.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/code-review.yml b/.github/workflows/code-review.yml index 7db6431..378b9f0 100644 --- a/.github/workflows/code-review.yml +++ b/.github/workflows/code-review.yml @@ -27,8 +27,8 @@ jobs: - name: Generate Diff id: generate-diff run: | - echo "Generating diff between ${{ github.base_ref }} and ${{ github.head_ref }}" - git diff --unified=5 origin/${{ github.base_ref }}...${{ github.head_ref }} > changes.diff + echo "Generating diff between origin/${{ github.base_ref }} and origin/${{ github.head_ref }}" + git diff --unified=5 origin/${{ github.base_ref }}...origin/${{ github.head_ref }} > changes.diff # - name: Generate Diff # id: generate-diff From d85a61776e5726d3ed79458379e330774382f04f Mon Sep 17 00:00:00 2001 From: LiteObject Date: Thu, 22 May 2025 21:11:03 -0500 Subject: [PATCH 2/2] Refactor Generate Diff step to remove commented-out code and ensure consistent diff generation --- .github/workflows/code-review.yml | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/.github/workflows/code-review.yml b/.github/workflows/code-review.yml index 378b9f0..b49cd81 100644 --- a/.github/workflows/code-review.yml +++ b/.github/workflows/code-review.yml @@ -28,13 +28,7 @@ jobs: id: generate-diff run: | echo "Generating diff between origin/${{ github.base_ref }} and origin/${{ github.head_ref }}" - git diff --unified=5 origin/${{ github.base_ref }}...origin/${{ github.head_ref }} > changes.diff - - # - name: Generate Diff - # id: generate-diff - # run: | - # echo "Generating diff between ${{ github.base_ref }} and pull request head" - # git diff --unified=0 origin/${{ github.event.pull_request.base.ref }}..FETCH_HEAD > changes.diff + git diff --unified=5 origin/${{ github.base_ref }}...origin/${{ github.head_ref }} > changes.diff - name: Sanitize Diff run: |