From cb0928df3ce5ebb21ed78f5b4b327b5416c09390 Mon Sep 17 00:00:00 2001 From: Joseph Frazer Date: Wed, 2 Nov 2016 13:35:17 -0400 Subject: [PATCH] fix typos in documentation and call renderStart (#5644) * call render-start when ad unit starts to load and fix typos in documentation * minor documentation changes --- ads/_config.js | 2 ++ ads/adblade.js | 5 +++++ ads/adblade.md | 8 ++++---- ads/industrybrains.md | 8 ++++---- 4 files changed, 15 insertions(+), 8 deletions(-) diff --git a/ads/_config.js b/ads/_config.js index 9f29edf64c04c..51aa250eab7cb 100644 --- a/ads/_config.js +++ b/ads/_config.js @@ -54,6 +54,7 @@ export const adConfig = { 'https://staticd.cdn.adblade.com', 'https://static.adblade.com', ], + renderStartImplemented: true, }, adform: {}, @@ -214,6 +215,7 @@ export const adConfig = { 'https://staticd.cdn.industrybrains.com', 'https://static.industrybrains.com', ], + renderStartImplemented: true, }, inmobi: { diff --git a/ads/adblade.js b/ads/adblade.js index 0441df706a323..230b7ae766995 100644 --- a/ads/adblade.js +++ b/ads/adblade.js @@ -34,6 +34,11 @@ function addAdiantUnit(hostname, global, data) { ins.setAttribute('data-tag-type', 1); global.document.getElementById('c').appendChild(ins); + ins.parentNode.addEventListener( + 'eventAdbladeRenderStart', + global.context.renderStart() + ); + // run our JavaScript code to display the ad unit writeScript(global, 'https://' + hostname + '/js/ads/async/show.js'); } diff --git a/ads/adblade.md b/ads/adblade.md index fb858109b8b68..ecd255e44113c 100644 --- a/ads/adblade.md +++ b/ads/adblade.md @@ -21,8 +21,8 @@ limitations under the License. ```html ``` @@ -34,5 +34,5 @@ For semantics of configuration, please see [ad network documentation](https://ww Supported parameters: - data-cid -- width -- height +- data-width +- data-height diff --git a/ads/industrybrains.md b/ads/industrybrains.md index e1045f0494913..72055f18c08a9 100644 --- a/ads/industrybrains.md +++ b/ads/industrybrains.md @@ -21,8 +21,8 @@ limitations under the License. ```html ``` @@ -34,5 +34,5 @@ For semantics of configuration, please see [ad network documentation](https://ww Supported parameters: - data-cid -- width -- height +- data-width +- data-height