Replace FillInExtraData
system with a new DataContext
object in IDataConvertableFrom
#495
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR modifies a significant chunk of the codebase for endpoints, so for an easier review I recommend just looking at only the files regarding the
DataContext
itself and the service for it.Key things to consider:
GameDatabaseContext.GetAssetFromHash
to return null for assets that will never be stored in the database. Simplifies some code and makes it faster.DataContext
service depends on most services, it must be added as the last service, always.DataContext.Game
andDataContext.Platform
both assumeWebsite
if a token is not present. This shouldn't ever be hit in Game API code but it's something to be aware of.DataContext
,DataContextService.StealInjection
does some illegal things by passingnull
for some parameters. This should be okay for the services that are already there, but I recommend looking at the servicesAddParameterToEndpoint
function when doing this just to make sure.