From 63460ab6a15a3fc4dbf3d365b71b55525bcffaed Mon Sep 17 00:00:00 2001
From: SeerLite <seerlite@tuta.io>
Date: Fri, 31 Jul 2020 21:35:27 -0400
Subject: [PATCH] Update readme with instructions for xfce terminal

---
 README.md | 11 +++++++++++
 1 file changed, 11 insertions(+)

diff --git a/README.md b/README.md
index e4bf12f..c9e60c5 100644
--- a/README.md
+++ b/README.md
@@ -75,6 +75,7 @@ They are evaluated through shell (sub shell), so most expressions should work. T
 * gnome
 * openbox
 * plasma
+* Xfce
 * herbstluftwm (by [cbf305](https://github.com/cbf305))
 
 ## Blacklisting
@@ -89,6 +90,7 @@ To the `blacklist` variable [space separated].
 ## Knows Issues
 * `sxiv` doesn't support this (as of now). https://github.com/muennich/sxiv/issues/398
     - Solution: https://github.com/elkowar/sxiv/tree/set_net_wm_pid (use this).
+* Wrong terminal is swallowed in Xfce: See [#WM specific recommendations/Xfce](#xfce)
 
 ## Tricks
 ### Manual swallow (toggle)
@@ -129,3 +131,12 @@ export PIDSWALLOW_PREGLUE_HOOK='bspc query -N -n {%pwid}.floating >/dev/null &&
 Check if parent window state is `floating` and apply the same to the child if that's the case.
 This example should work in most cases, but feel free to add more complex hooks to your setup. (e.g. to mimic more properties of the parent).
 
+### Xfce
+By default, every Xfce Terminal is connected to the same D-Bus daemon. This makes it hard for pidswallow to see which terminal should be swallowed, since they all share the same PID.
+As a workaround, you can edit the Xfce Terminal launcher to use the `--disable-server` flag:
+1. Open Application Finder
+2. Search for "Xfce Terminal"
+3. Right click the result that has "Terminal Emulator" as its description and click Edit
+4. Change the "Command" field to `xfce4-terminal --disable-server`
+5. Save
+