This repository was archived by the owner on May 11, 2026. It is now read-only.
feat(MT-1912): update LiveIntent SDK to support new createGAMUrl function from lfx in gamma-api #11
Merged
Conversation
ashishkumarqait
force-pushed
the
story/MT-1912
branch
from
fe97783 to
959f3c6
Compare
ashishkumarqait
changed the title
ashishkumarqait
force-pushed
the
story/MT-1912
branch
from
959f3c6 to
ce48f0e
Compare
ashishkumarqait
changed the title
ashishkumarqait
changed the title
ashishkumarqait
commented
Jun 9, 2022
ashishkumarqait
commented
Jun 9, 2022
ashishkumarqait
commented
Jun 9, 2022
ashishkumarqait
commented
Jun 9, 2022
ashishkumarqait
commented
Jun 9, 2022
ashishkumarqait
commented
Jun 9, 2022
tzanetti-liveintent
suggested changes
Jun 9, 2022
tzanetti-liveintent
left a comment
tzanetti-liveintent
left a comment
There was a problem hiding this comment.
Mostly looks good, but waiting for some questions to be answered.
ashishkumarqait
commented
Jun 10, 2022
tam5
suggested changes
Jun 10, 2022
|
|
||
| $dotenv = Dotenv::createImmutable(dirname(__DIR__)); | ||
| $dotenv->safeLoad(); | ||
| // Do something which should run for each test file (if needed), env variable loading is moved to bootstraping |
There was a problem hiding this comment.
do we need this comment here? and in fact, if there is nothing in the setup method, maybe we don't need to define it at all
Contributor
Author
There was a problem hiding this comment.
Lets keep a base TestCase file, will remove comment
tam5
approved these changes
Jun 10, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.